Selenium - 4 changes#2
Merged
francisf merged 12 commits intobrowserstack:selenium-4from Apr 12, 2022
Merged
Conversation
Ankit098
reviewed
Apr 8, 2022
Contributor
Author
|
@Ankit098 Changes are done, please review, |
Collaborator
|
have added some comments to the PR#3, let's apply the relevant ones here as well, like the conf structure and having code more readable.. Yep, verify the local issue as well. |
Collaborator
|
Also you have raised both PRs against |
Ankit098
reviewed
Apr 11, 2022
Collaborator
Ankit098
left a comment
There was a problem hiding this comment.
Minor comment regarding conf file, other than that LGTM
Ankit098
reviewed
Apr 11, 2022
Co-authored-by: Ankit Singh <51696887+Ankit098@users.noreply.github.com>
Ankit098
approved these changes
Apr 11, 2022
Ankit098
approved these changes
Apr 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.