Skip to content

Selenium - 4 changes#2

Merged
francisf merged 12 commits intobrowserstack:selenium-4from
RutvikChandla:selenium-4
Apr 12, 2022
Merged

Selenium - 4 changes#2
francisf merged 12 commits intobrowserstack:selenium-4from
RutvikChandla:selenium-4

Conversation

@RutvikChandla
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .gitignore Outdated
Comment thread README.md Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread scripts/local.js Outdated
Comment thread scripts/local.js Outdated
Comment thread scripts/parallel.js Outdated
Comment thread scripts/parallel.js Outdated
Comment thread scripts/single.js Outdated
Comment thread scripts/single.js Outdated
@RutvikChandla RutvikChandla requested a review from Ankit098 April 11, 2022 05:06
@RutvikChandla
Copy link
Copy Markdown
Contributor Author

@Ankit098 Changes are done, please review, bs_local.isRunning() is returning undefined so have not put try catch there, will discuss this with the team, else please session is running properly.

@Ankit098
Copy link
Copy Markdown
Collaborator

have added some comments to the PR#3, let's apply the relevant ones here as well, like the conf structure and having code more readable.. Yep, verify the local issue as well.

@Ankit098
Copy link
Copy Markdown
Collaborator

Also you have raised both PRs against main branch, one of these would have a different target branch, please confirm and update the target branch for one of the PRs

@RutvikChandla RutvikChandla changed the base branch from main to selenium-4 April 11, 2022 10:35
Copy link
Copy Markdown
Collaborator

@Ankit098 Ankit098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment regarding conf file, other than that LGTM

Comment thread conf.js Outdated
Comment thread conf.js Outdated
Comment thread README.md Outdated
Co-authored-by: Ankit Singh <51696887+Ankit098@users.noreply.github.com>
@francisf francisf merged commit d390021 into browserstack:selenium-4 Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants